Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load etcd configuration when apisix starts #3799

Merged
merged 1 commit into from
Mar 12, 2021
Merged

feat: load etcd configuration when apisix starts #3799

merged 1 commit into from
Mar 12, 2021

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Mar 10, 2021 •
edited
Loading

Fix #3370
Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander changed the title WIP feat: load etcd configuration when apisix starts Mar 10, 2021
@spacewander spacewander force-pushed the etcd_init branch 2 times, most recently from a625b48 to 9d55aa2 Compare March 10, 2021 10:29
@spacewander
feat: load etcd configuration when apisix starts
7dfdad2 
Fix apache#3370
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review March 10, 2021 12:11
membphis
membphis reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting PR, welcome @tokers to take a look

@tokers
Copy link
Contributor

tokers commented Mar 10, 2021

This is an interesting PR, welcome @tokers to take a look

OK.

nic-chen
nic-chen reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some time to read the code..

@tokers tokers merged commit 83537ad into apache:master Mar 12, 2021
@spacewander spacewander mentioned this pull request Mar 17, 2021
Closed
@soulbird soulbird mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis left review comments

@tokers tokers tokers approved these changes

@nic-chen nic-chen nic-chen approved these changes

@Yiyiyimu Yiyiyimu Awaiting requested review from Yiyiyimu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: http service should not be started before etcd data is pulled
4 participants
@spacewander @tokers @membphis @nic-chen