feat(skywalking): allow destory and configure report interval for rep… #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orter Fix apache#2895 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Firstsawyou
suggested changes
Mar 29, 2021
docs/en/latest/plugins/skywalking.md
Outdated
| @@ -92,6 +92,7 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`. | |||
| | service_name | string | "APISIX" | service name for skywalking reporter | | |||
| |service_instance_name|string|"APISIX Instance Name" | service instance name for skywalking reporter | | |||
| | endpoint | string | "http://127.0.0.1:12800" | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | | |||
There was a problem hiding this comment.
Suggested change
| | endpoint | string | "http://127.0.0.1:12800" | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | | |
| | endpoint_addr | string | "http://127.0.0.1:12800" | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | |
The endpoint field name is typo, we should fix it by the way?
docs/zh/latest/plugins/skywalking.md
Outdated
| @@ -96,6 +96,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 | |||
| | service_name | string | "APISIX" | skywalking 上报的 service 名称 | | |||
| |service_instance_name|string| "APISIX Instance Name" | skywalking 上报的 service 实例名 | | |||
| | endpoint | string | "http://127.0.0.1:12800" | Skywalking 的 HTTP endpoint 地址，例如：http://127.0.0.1:12800 | | |||
There was a problem hiding this comment.
@Firstsawyou
Updated.
tokers
approved these changes
Mar 29, 2021
membphis
approved these changes
Mar 29, 2021
apisix/plugins/skywalking.lua
Outdated
| sk_cli:startBackendTimer(local_plugin_info.endpoint_addr) | ||
| end | ||
|
|
||
|
|
||
| function _M.destroy() | ||
| if process.type() ~= "worker" and process.type() ~= "single" then |
There was a problem hiding this comment.
we can remove process.type() ~= "single", right?
| @@ -91,7 +91,8 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`. | |||
| | ------------ | ------ | -------- | -------------------------------------------------------------------- | | |||
| | service_name | string | "APISIX" | service name for skywalking reporter | | |||
| |service_instance_name|string|"APISIX Instance Name" | service instance name for skywalking reporter | | |||
| | endpoint | string | "http://127.0.0.1:12800" | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | | |||
| | endpoint_addr| string | "http://127.0.0.1:12800" | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | | |||
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
defp
pushed a commit
to defp/apisix
that referenced
this pull request
Apr 3, 2021
…orter (apache#3925) Fix apache#2895 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…orter
Fix #2895
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: