Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(prometheus): don't expose metrics to internet #3994

Merged
merged 1 commit into from
Apr 7, 2021
Merged

change(prometheus): don't expose metrics to internet #3994

merged 1 commit into from
Apr 7, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander force-pushed the pro branch 2 times, most recently from 7e41b56 to 8fc0792 Compare April 6, 2021 11:15
@spacewander
change(prometheus): don't expose metrics to internet
9fd6191 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review April 6, 2021 12:09
@spacewander spacewander requested review from membphis and starsz April 6, 2021 12:10
membphis
membphis approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice way, LGTM

@starsz starsz requested a review from nic-chen April 7, 2021 01:26
@spacewander spacewander merged commit 6a986f4 into apache:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@tokers tokers tokers approved these changes

@starsz starsz starsz approved these changes

@nic-chen nic-chen nic-chen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spacewander @membphis @tokers @starsz @nic-chen