Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Polish SkyWalking doc and a tiny thing about Zipkin #4339

Merged
merged 6 commits into from
May 31, 2021

Conversation

wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented May 30, 2021

What this PR does / why we need it:

Neither Zipkin nor SkyWalking is a part of OpenTracing ecosystem, especially when we speak from Nginx and LUA perspectives. Also, OpenTracing is being abandoned, their APIs are not widely used, and merged into OpenTelemetry, which also doesn't relate to the Nginx ecosystem. So, let's focus on the tech itself.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@wu-sheng wu-sheng added the doc Documentation things label May 30, 2021
@wu-sheng wu-sheng added this to the 2.7 milestone May 30, 2021
@wu-sheng wu-sheng requested a review from juzhiyuan May 30, 2021 07:55
README.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/skywalking.md Outdated Show resolved Hide resolved
@juzhiyuan juzhiyuan changed the title Polish SkyWalking doc and a tiny thing about Zipkin docs: Polish SkyWalking doc and a tiny thing about Zipkin May 30, 2021
wu-sheng and others added 2 commits May 30, 2021 20:49
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
@wu-sheng
Copy link
Member Author

Why CI get canceled?

@wu-sheng wu-sheng requested a review from juzhiyuan May 30, 2021 13:15
@juzhiyuan
Copy link
Member

@wu-sheng
Copy link
Member Author

Why CI get canceled?

See https://github.com/apache/apisix/tree/master/.github/actions

SkyWalking has this, but never cancels CI for the latest commit. What do I miss?

@juzhiyuan
Copy link
Member

Why CI get canceled?

See https://github.com/apache/apisix/tree/master/.github/actions

SkyWalking has this, but never cancels CI for the latest commit. What do I miss?

got it. 😳 You mean the last commit's checks are cancelled unexpectedly, need @Yiyiyimu to confirm.

@juzhiyuan
Copy link
Member

juzhiyuan commented May 30, 2021

AFAIK, we have paths_ignore in most checks for docs changes, do they have a relationship? 🤔

image

image

Those checks won't run.

@Yiyiyimu
Copy link
Member

Yiyiyimu commented May 30, 2021

AFAIK, we have paths_ignore in most checks for docs changes, do they have a relationship? 🤔

Since this PR also changes README, so all CI would be running. Still checking the reason.


I guess a part of the reason is that this PR is not coming from a forked repo, like most PRs. The rule of cancel-workflow-action is kind of sophisticated, and just got noticed that It got deprecated since Github provides an official feature about it so I guess I would not fix it (since for this PR doc change does not need all CI passed), but try to apply the new one.

Co-authored-by: Shuyang Wu <wosoyoung@gmail.com>
@wu-sheng wu-sheng requested a review from Yiyiyimu May 31, 2021 00:58
@Yiyiyimu Yiyiyimu merged commit 09e2983 into master May 31, 2021
@Yiyiyimu Yiyiyimu deleted the sw-doc-polish branch May 31, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants