-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Polish SkyWalking doc and a tiny thing about Zipkin #4339
Conversation
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Why CI get canceled? |
See https://github.com/apache/apisix/tree/master/.github/actions |
SkyWalking has this, but never cancels CI for the latest commit. What do I miss? |
got it. 😳 You mean the last commit's checks are cancelled unexpectedly, need @Yiyiyimu to confirm. |
Since this PR also changes README, so all CI would be running. Still checking the reason. I guess a part of the reason is that this PR is not coming from a forked repo, like most PRs. The rule of |
Co-authored-by: Shuyang Wu <wosoyoung@gmail.com>
What this PR does / why we need it:
Neither Zipkin nor SkyWalking is a part of OpenTracing ecosystem, especially when we speak from Nginx and LUA perspectives. Also, OpenTracing is being abandoned, their APIs are not widely used, and merged into OpenTelemetry, which also doesn't relate to the Nginx ecosystem. So, let's focus on the tech itself.
Pre-submission checklist: