test: make t/chaos/kill-chaos.t stable #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
spacewander
approved these changes
Jun 30, 2021
tokers
reviewed
Jun 30, 2021
| @@ -158,16 +158,16 @@ func getPrometheusMetric(e *httpexpect.Expect, g *WithT, key string) string { | |||
| return targetSlice[1] | |||
| } | |||
|
|
|||
| func getIngressBandwidthPerSecond(e *httpexpect.Expect, g *WithT) (float64, float64) { | |||
| key := "apisix_bandwidth{type=\"ingress\"," | |||
| func getEgressBandwidthPerSecond(e *httpexpect.Expect, g *WithT) (float64, float64) { | |||
There was a problem hiding this comment.
Why even the semantics of this function was changed?
There was a problem hiding this comment.
changed to egress bps comparison as measurement, since egress is what expected to be the same
4 tasks
tokers
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yiyiyimu wosoyoung@gmail.com
What this PR does / why we need it:
fix #4437
Can not reproduce in the local environment. Try to make it stable by receiving more requests in a certain time period, to make bandwidth-per-second comparison more stable.
Also changed to egress bps comparison as measurement, since egress is what expected to be the same.
Pre-submission checklist: