Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the limit-conn plugin cannot effectively intercept requests in special scenarios #4585

Merged
merged 16 commits into from
Jul 16, 2021
Merged

fix: the limit-conn plugin cannot effectively intercept requests in special scenarios #4585

merged 16 commits into from
Jul 16, 2021

Conversation

zuiyangqingzhou
Copy link
Contributor

@zuiyangqingzhou zuiyangqingzhou commented Jul 11, 2021 •
edited by spacewander
Loading

What this PR does / why we need it:

fix 4556

ps: I will add test cases in the next two days

@tokers
Copy link
Contributor

tokers commented Jul 12, 2021

@zuiyangqingzhou The PR title is subtle, it cannot reflect what did this PR do. Please change it.

@zuiyangqingzhou
Copy link
Contributor Author

@zuiyangqingzhou The PR title is subtle, it cannot reflect what did this PR do. Please change it.

sorry, i will fix it

@zuiyangqingzhou zuiyangqingzhou changed the title Fix limit conn fix the bug of limit-conn plug-in in special scenarios Jul 12, 2021
@zuiyangqingzhou zuiyangqingzhou changed the title fix the bug of limit-conn plug-in in special scenarios fix: the limit-conn plugin cannot effectively intercept requests in special scenarios Jul 12, 2021
@spacewander
Copy link
Member

@zuiyangqingzhou
Would you add some test case?

@zuiyangqingzhou
Copy link
Contributor Author

@zuiyangqingzhou
Would you add some test case?

sorry, this week is busy, I will try my best to add test case, or if you are willing to help me, I will thank you very much

@spacewander
Copy link
Member

@zuiyangqingzhou
Would you add some test case?

sorry, this week is busy, I will try my best to add test case, or if you are willing to help me, I will thank you very much

I will take care of it soon.

@zuiyangqingzhou
Copy link
Contributor Author

@zuiyangqingzhou
Would you add some test case?

sorry, this week is busy, I will try my best to add test case, or if you are willing to help me, I will thank you very much

I will take care of it soon.

awesome, 👍🏻

spacewander and others added 3 commits July 16, 2021 10:17
@spacewander
Merge branch 'master' into fix-limit-conn
697c62f 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander
test
ce8f478 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@zuiyangqingzhou
Merge branch 'apache:master' into fix-limit-conn
65d7602
@spacewander spacewander mentioned this pull request Jul 16, 2021
Merged
@tokers tokers merged commit 554a30e into apache:master Jul 16, 2021
@zuiyangqingzhou zuiyangqingzhou deleted the fix-limit-conn branch July 18, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: the limit-conn plugin has a bug
3 participants
@zuiyangqingzhou @tokers @spacewander