Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin): check username for updating consumer #4756

Merged
merged 5 commits into from
Aug 5, 2021
Merged

fix(admin): check username for updating consumer #4756

merged 5 commits into from
Aug 5, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Aug 5, 2021 •
edited
Loading

What this PR does / why we need it:

fix #4680

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander changed the title fix: check username for updating consumer fix(admin): check username for updating consumer Aug 5, 2021
spacewander
spacewander reviewed Aug 5, 2021
View reviewed changes
t/admin/consumers2.t Outdated Show resolved Hide resolved
t/admin/consumers2.t Outdated Show resolved Hide resolved
okaybase and others added 2 commits August 5, 2021 11:42
@okaybase @spacewander
change say to print
97cb297 
Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>
@okaybase
test mismatched username
2d064f8
@tokers tokers merged commit 76f53e3 into apache:master Aug 5, 2021
@okaybase okaybase deleted the patch-consumer branch August 5, 2021 11:50
@spacewander spacewander mentioned this pull request Aug 6, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: It should return 400 when update consumer with mismatched username in path and body
3 participants
@okaybase @spacewander @tokers