Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(limit-*): add custom reject-message for traffic control #4808

Merged
merged 10 commits into from
Aug 13, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Aug 12, 2021

What this PR does / why we need it:

Add custom reject-message for traffic control, service provider can tell the caller what happens.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

t/plugin/limit-conn.t Outdated Show resolved Hide resolved
docs/zh/latest/plugins/limit-conn.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/limit-req.md Outdated Show resolved Hide resolved
apisix/plugins/limit-conn/init.lua Outdated Show resolved Hide resolved
t/plugin/limit-count-redis-cluster.t Outdated Show resolved Hide resolved
t/plugin/limit-count-redis-cluster.t Outdated Show resolved Hide resolved
t/plugin/limit-count.t Outdated Show resolved Hide resolved
t/plugin/limit-conn2.t Outdated Show resolved Hide resolved
t/plugin/limit-count.t Outdated Show resolved Hide resolved
docs/en/latest/plugins/limit-conn.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/limit-conn.md Outdated Show resolved Hide resolved
@tzssangglass
Copy link
Member

@spacewander I think we need to unify the rejected_code and rejected_msg attributes of the limit-req, limit-conn and limit-count.

At present they look somewhat incongruous.

@spacewander spacewander changed the title feat(plugin): add custom reject-message for traffic control feat(limit-*): add custom reject-message for traffic control Aug 13, 2021
@spacewander spacewander merged commit b7cbaed into apache:master Aug 13, 2021
@okaybase okaybase deleted the return-value branch August 13, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants