Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add question issue template #4833

Merged
merged 2 commits into from
Aug 17, 2021
Merged

feat: add question issue template #4833

merged 2 commits into from
Aug 17, 2021

Conversation

Yangxiamao
Copy link
Contributor

What this PR does / why we need it:

I add question issue template, so we can jump to the APISIX discussion forum from the Issues.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

spacewander
spacewander reviewed Aug 16, 2021
View reviewed changes
.github/ISSUE_TEMPLATE/config.yml Outdated
@@ -0,0 +1,5 @@
blank_issues_enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why allow the blank issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the meaning of this option, my false. We can change this setting to "false"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required for the APISIX discussion forum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We want all support questions to go to Discussions. But people are used to create issues. It will take long time until everyone learns the new feature. Having a big green button in the issue creation seems like a good idea.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I mean whether "blank_issues_enabled" is required for the APISIX discussion forum. Allow blank issues or not seems to be irrelative to the discussion forum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can encourage contributors to use issue templates by setting blank_issues_enabled to false. If we set blank_issues_enabled to true, people will have the option to open a blank issue.
Do you think it is necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@spacewander spacewander merged commit b0246c8 into apache:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yangxiamao @spacewander @tokers