feat(kafka-logger): add cluster name support #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Aug 23, 2021
apisix/plugins/kafka-logger.lua
Outdated
| @@ -60,7 +59,8 @@ local schema = { | |||
| buffer_duration = {type = "integer", minimum = 1, default = 60}, | |||
| inactive_timeout = {type = "integer", minimum = 1, default = 5}, | |||
| batch_max_size = {type = "integer", minimum = 1, default = 1000}, | |||
| include_req_body = {type = "boolean", default = false} | |||
| include_req_body = {type = "boolean", default = false}, | |||
| cluster_name = {type = "integer", default = 1}, | |||
There was a problem hiding this comment.
Do you need to limit the minimum value?
There was a problem hiding this comment.
It confuses me, why name is an integer?
There was a problem hiding this comment.
It confuses me, why name is an integer?
follow the origin design: https://github.com/doujiang24/lua-resty-kafka#new-1
The third optional cluster_name specifies the name of the cluster, default 1 (yeah, it's number). You can Specifies different names when you have two or more kafka clusters. And this only works with async producer_type.
I think using numbers should satisfy the need.
There was a problem hiding this comment.
Could you add it as a comment?
There was a problem hiding this comment.
Should we highlight that this is a design in the documents?
spacewander
reviewed
Aug 24, 2021
apisix/plugins/kafka-logger.lua
Outdated
| @@ -60,7 +59,8 @@ local schema = { | |||
| buffer_duration = {type = "integer", minimum = 1, default = 60}, | |||
| inactive_timeout = {type = "integer", minimum = 1, default = 5}, | |||
| batch_max_size = {type = "integer", minimum = 1, default = 1000}, | |||
| include_req_body = {type = "boolean", default = false} | |||
| include_req_body = {type = "boolean", default = false}, | |||
| cluster_name = {type = "integer", default = 1}, | |||
There was a problem hiding this comment.
Could you add it as a comment?
spacewander
approved these changes
Aug 25, 2021
tokers
approved these changes
Aug 25, 2021
|
@tzssangglass Please fix the conflicts. |
� Conflicts: � t/plugin/kafka-logger.t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
about the cluster_name of kafka producer: https://github.com/doujiang24/lua-resty-kafka#new-1
Pre-submission checklist: