Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configuring admin specific IP #4967

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

wayne-cheng
Copy link
Contributor

Signed-off-by: wayne-cheng zhengwei@tiduyun.com

What this PR does / why we need it:

This is the next PR from #4856 (comment)
It's used to support configurating the admin listening address.
The config.yaml example as below:

apisix:
  admin_listen:            # use a separate port
    ip: 127.0.0.2           # Specific IP, if not set, the default value is `0.0.0.0`.
    port: 9180
  #port_admin: 9180   # Not recommend: This parameter should be set via the `admin_listen`.

PTAL @spacewander

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: wayne-cheng <zhengwei@tiduyun.com>
@spacewander spacewander changed the title feat: support configrating admin specific IP feat: support configuring admin specific IP Sep 2, 2021
@spacewander spacewander merged commit 2d07ec4 into apache:master Sep 2, 2021
@wayne-cheng wayne-cheng deleted the feat-admin-listen branch September 3, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants