Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow route to inherit hosts from service #4977

Merged
merged 2 commits into from
Sep 6, 2021
Merged

feat: allow route to inherit hosts from service #4977

merged 2 commits into from
Sep 6, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
feat: allow route to inherit hosts from service
035899f 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review September 3, 2021 04:02
@spacewander
more test
448aee1 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander merged commit 0ba89d5 into apache:master Sep 6, 2021
@spacewander spacewander deleted the shh branch September 6, 2021 00:57
@Donghui0
Copy link
Contributor

in plugin.merge_service_route function, need to add processing for route.value.timeout. Otherwise, the timeout attribute of ApisixRoute will be invalid.

I have a question in the merge service_route method. Why not directly core.table.deepcopy(route_conf), assign the attribute of service to new_conf ?

@Donghui0 Donghui0 mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-chen nic-chen nic-chen approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@tokers tokers tokers approved these changes

@membphis membphis Awaiting requested review from membphis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spacewander @Donghui0 @tokers @tzssangglass @nic-chen