change(debug): move 'enable_debug' form config.yaml to debug.yaml #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokers
approved these changes
Sep 13, 2021
| 设置 `conf/config.yaml` 中的 `apisix.enable_debug` 为 `true`，即可开启基本调试模式。 | ||
| 设置 `conf/debug.yaml` 中的 `enable_debug` 为 `true`，即可开启基本调试模式。 |
There was a problem hiding this comment.
Hi, for those who using apisix versions before 2.9.0, this document may be confused
There was a problem hiding this comment.
We can add a note for the version before 2.10.0?
spacewander
reviewed
Sep 14, 2021
conf/debug.yaml
Outdated
| @@ -14,6 +14,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # | |||
| enable_debug: false | |||
There was a problem hiding this comment.
Suggested change
| enable_debug: false | |
| basic: | |
| enable: false |
would be better?
There was a problem hiding this comment.
Looks better, but this enable will conflict with
Line 34 in b52f95b
I don't know how to modify this with perl.
spacewander
approved these changes
Sep 14, 2021
spacewander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
move 'enable_debug' form config.yaml to debug.yaml, make the configuration of debug mode clear and central
Pre-submission checklist: