Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nacos): distinguish services that has same name but in different groups or namespaces #5083

Merged
merged 16 commits into from
Sep 23, 2021

Conversation

tzssangglass
Copy link
Member

What this PR does / why we need it:

fix #5061

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tzssangglass
Copy link
Member Author

tzssangglass commented Sep 17, 2021

base on api7/nacos-test-service#2

apisix/discovery/nacos.lua Outdated Show resolved Hide resolved
apisix/discovery/nacos.lua Outdated Show resolved Hide resolved
apisix/discovery/nacos.lua Outdated Show resolved Hide resolved
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
…espace_id

Signed-off-by: tzssangglass <tzssangglass@gmail.com>
…o5061

� Conflicts:
�	apisix/discovery/nacos.lua
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
@spacewander spacewander merged commit 2ead265 into apache:master Sep 23, 2021
@tzssangglass tzssangglass deleted the IssueNo5061 branch October 26, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug:nacos.lua 脚本 同样的服务名称不同分组的实例,会存储到同一个nacos服务节点中
4 participants