Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: response.set_header should remove header like request.set_header #5499

Merged
merged 1 commit into from
Nov 14, 2021
Merged

fix: response.set_header should remove header like request.set_header #5499

merged 1 commit into from
Nov 14, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
fix: response.set_header can remove header like request.set_header
a763cd5 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review November 13, 2021 06:46
@spacewander spacewander changed the title fix: response.set_header can remove header like request.set_header fix: response.set_header should remove header like request.set_header Nov 13, 2021
@membphis membphis merged commit 6c5108f into apache:master Nov 14, 2021
tzssangglass pushed a commit to tzssangglass/apisix that referenced this pull request Nov 15, 2021
@spacewander @tzssangglass
fix: response.set_header can remove header like request.set_header (a…
6f3e26d 
…pache#5499)

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
(cherry picked from commit 6c5108f)
tzssangglass pushed a commit to tzssangglass/apisix that referenced this pull request Nov 15, 2021
@spacewander @tzssangglass
fix: response.set_header can remove header like request.set_header (a…
ed84868 
…pache#5499)

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
(cherry picked from commit 6c5108f)
tzssangglass pushed a commit to tzssangglass/apisix that referenced this pull request Nov 15, 2021
@spacewander @tzssangglass
fix: response.set_header can remove header like request.set_header (a…
556270a 
…pache#5499)

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
(cherry picked from commit 6c5108f)
tzssangglass pushed a commit to tzssangglass/apisix that referenced this pull request Nov 15, 2021
@spacewander @tzssangglass
fix: response.set_header can remove header like request.set_header (a…
9362ddf 
…pache#5499)

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
(cherry picked from commit 6c5108f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacewander @membphis @tokers