-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka-logger): supports logging request body #5501
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
613c19e
feat(kafka-logger) kafka logger supports logging request body (#5343)
acb54e3
reindex
fb04109
optimize
d922ffd
change test kafka topic test2
3e867ea
optimize
f691471
optimize test
d82854c
lint
a017631
optimize
7ea1b17
optimize
d31a5ab
lint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1114,3 +1114,82 @@ GET /t | |
--- error_log_like eval | ||
qr/create new kafka producer instance, brokers: \[\{"port":9092,"host":"127.0.0.127"}]/ | ||
qr/failed to send data to Kafka topic: .*, brokers: \{"127.0.0.127":9092}/ | ||
|
||
|
||
|
||
=== TEST 26: set route(id: 1,include_req_body = true,include_req_body_expr = array) | ||
--- config | ||
location /t { | ||
content_by_lua_block { | ||
local t = require("lib.test_admin").test | ||
local code, body = t('/apisix/admin/routes/1', | ||
ngx.HTTP_PUT, | ||
[=[{ | ||
"plugins": { | ||
"kafka-logger": { | ||
"broker_list" : | ||
{ | ||
"127.0.0.1":9092 | ||
}, | ||
"kafka_topic" : "test2", | ||
"key" : "key1", | ||
"timeout" : 1, | ||
"include_req_body": true, | ||
"include_req_body_expr": [ | ||
[ | ||
"arg_name", | ||
"==", | ||
"qwerty" | ||
] | ||
], | ||
"batch_max_size": 1 | ||
} | ||
}, | ||
"upstream": { | ||
"nodes": { | ||
"127.0.0.1:1980": 1 | ||
}, | ||
"type": "roundrobin" | ||
}, | ||
"uri": "/hello" | ||
}]=] | ||
) | ||
if code >= 300 then | ||
ngx.status = code | ||
end | ||
ngx.say(body) | ||
} | ||
} | ||
|
||
--- request | ||
GET /t | ||
--- response_body | ||
passed | ||
--- no_error_log | ||
[error] | ||
|
||
|
||
|
||
=== TEST 27: hit route, expr eval success | ||
--- request | ||
POST /hello?name=qwerty | ||
abcdef | ||
--- response_body | ||
hello world | ||
--- no_error_log | ||
[error] | ||
--- error_log eval | ||
qr/send data to kafka: \{.*"body":"abcdef"/ | ||
--- wait: 2 | ||
|
||
|
||
|
||
=== TEST 28: hit route,expr eval fail | ||
--- request | ||
POST /hello?name=zcxv | ||
abcdef | ||
--- response_body | ||
hello world | ||
--- no_error_log eval | ||
qr/send data to kafka: \{.*"body":"abcdef"/ | ||
--- wait: 2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we can merge it, could you add a check for the expr in the
check_schema
? Like:apisix/apisix/plugins/response-rewrite.lua
Line 111 in 9b355c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done