Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): support google cloud logging service #5538

Merged
merged 14 commits into from
Nov 23, 2021
Merged

feat(plugin): support google cloud logging service #5538

merged 14 commits into from
Nov 23, 2021

Conversation

shuaijinchao
Copy link
Member

@shuaijinchao shuaijinchao commented Nov 17, 2021 •
edited
Loading

What this PR does / why we need it:

FIX #5474

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@shuaijinchao shuaijinchao marked this pull request as ready for review November 19, 2021 08:46
tokers
tokers reviewed Nov 19, 2021
View reviewed changes
Copy link
Contributor

@tokers tokers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple review round with some questions.

apisix/plugins/google-logging/oauth.lua Outdated Show resolved Hide resolved
docs/en/latest/plugins/google-logging.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/google-logging.md Outdated Show resolved Hide resolved
t/lib/server.lua Outdated Show resolved Hide resolved
@shuaijinchao
Merge branch 'feature/plugin/google/logging' of github.com:shuaijinch…
7eef5b5 
…ao/apisix into feature/plugin/google/logging2

� Conflicts:
�	conf/config-default.yaml
@shuaijinchao
chore: update document and test server
19d5450
spacewander
spacewander reviewed Nov 21, 2021
View reviewed changes
apisix/core/utils.lua Outdated Show resolved Hide resolved
apisix/plugins/google-logging.lua Outdated Show resolved Hide resolved
apisix/plugins/google-logging.lua Outdated Show resolved Hide resolved
apisix/plugins/google-logging.lua Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
docs/en/latest/plugins/google-logging.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/google-logging.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/google-logging.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/google-logging.md Outdated Show resolved Hide resolved
apisix/plugins/google-logging.lua Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Nov 21, 2021
View reviewed changes
t/plugin/google-logging.t Outdated Show resolved Hide resolved
t/plugin/google-logging.t Outdated Show resolved Hide resolved
@spacewander spacewander merged commit 59497de into apache:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@tokers tokers Awaiting requested review from tokers

@juzhiyuan juzhiyuan Awaiting requested review from juzhiyuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: support google cloud logging service plugin
5 participants
@shuaijinchao @juzhiyuan @spacewander @tokers @tzssangglass