Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patch): add global math.randomseed patch support #5682

Merged
merged 12 commits into from
Dec 7, 2021
Merged

fix(patch): add global math.randomseed patch support #5682

merged 12 commits into from
Dec 7, 2021

Conversation

leslie-tsang
Copy link
Member

@leslie-tsang leslie-tsang commented Dec 3, 2021 •
edited
Loading

What this PR does / why we need it:

Kong solution Ref to #5417

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@leslie-tsang
Copy link
Member Author

@spacewander Please take a look, Thanks !

@spacewander
Copy link
Member

Please fix the lint.

moonming
moonming requested changes Dec 5, 2021
View reviewed changes
apisix/patch.lua Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Dec 5, 2021
View reviewed changes
apisix/patch.lua Outdated Show resolved Hide resolved
apisix/patch.lua Outdated Show resolved Hide resolved
apisix/patch.lua Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Dec 5, 2021
View reviewed changes
apisix/patch.lua Outdated Show resolved Hide resolved
.luacheckrc Outdated Show resolved Hide resolved
spacewander
spacewander approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, please don't use force-push for a reviewing PR.

apisix/patch.lua Outdated Show resolved Hide resolved
@leslie-tsang @spacewander
chore: apply suggestion from spacewander
f9bc5a3 
Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>
moonming
moonming requested changes Dec 7, 2021
View reviewed changes
apisix/patch.lua Outdated Show resolved Hide resolved
tzssangglass
tzssangglass reviewed Dec 7, 2021
View reviewed changes
apisix/patch.lua Outdated Show resolved Hide resolved
apisix/patch.lua Outdated Show resolved Hide resolved
@spacewander spacewander merged commit b85ebd4 into apache:master Dec 7, 2021
bzp2010 pushed a commit to bzp2010/apisix that referenced this pull request Dec 30, 2021
@leslie-tsang @spacewander @bzp2010
fix(patch): add global math.randomseed patch support (apache#5682)
8cffb03 
Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>
bzp2010 pushed a commit to bzp2010/apisix that referenced this pull request Dec 30, 2021
@leslie-tsang @spacewander @bzp2010
fix(patch): add global math.randomseed patch support (apache#5682)
603979d 
Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>
@leslie-tsang leslie-tsang deleted the bugfix/issue-5417-auto-generated-id branch January 5, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers left review comments

@moonming moonming moonming approved these changes

@spacewander spacewander Awaiting requested review from spacewander

@tzssangglass tzssangglass Awaiting requested review from tzssangglass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leslie-tsang @spacewander @tokers @moonming @tzssangglass