Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log-rotate): after enabling compression collect log exceptions #5715

Merged
merged 5 commits into from
Dec 8, 2021

Conversation

shuaijinchao
Copy link
Member

What this PR does / why we need it:

FIX #5658
FIX #5663

process

Before FIX: rename log -> compression log -> nginx reopen
After FIX: rename log -> nginx reopen -> compression log

refer to:
https://nginx.org/en/docs/control.html#logs

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

apisix/plugins/log-rotate.lua Show resolved Hide resolved
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
@spacewander spacewander merged commit 139c397 into apache:master Dec 8, 2021
shuaijinchao added a commit to shuaijinchao/apisix that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: log-rotate.lua request help: unable to collect logs when log-rotate plugin is enabled
4 participants