Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(splunk): support splunk hec logging plugin #5819

Merged
merged 15 commits into from
Dec 20, 2021
Merged

feat(splunk): support splunk hec logging plugin #5819

merged 15 commits into from
Dec 20, 2021

Conversation

shuaijinchao
Copy link
Member

@shuaijinchao shuaijinchao commented Dec 15, 2021 •
edited
Loading

What this PR does / why we need it:

FIX #5636

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@shuaijinchao shuaijinchao marked this pull request as ready for review December 16, 2021 14:19
spacewander
spacewander reviewed Dec 17, 2021
View reviewed changes
apisix/plugins/splunk-hec-logging.lua Outdated Show resolved Hide resolved
apisix/plugins/splunk-hec-logging.lua Outdated Show resolved Hide resolved
apisix/plugins/splunk-hec-logging.lua Outdated Show resolved Hide resolved
apisix/plugins/splunk-hec-logging.lua Show resolved Hide resolved
conf/config-default.yaml Outdated Show resolved Hide resolved
docs/en/latest/plugins/splunk-hec-logging.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/splunk-hec-logging.md Outdated Show resolved Hide resolved
t/plugin/splunk-hec-logging.t Outdated Show resolved Hide resolved
t/plugin/splunk-hec-logging.t Outdated Show resolved Hide resolved
spacewander
spacewander approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve except #5819 (comment)

membphis
membphis reviewed Dec 19, 2021
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update README.md

@shuaijinchao
Copy link
Member Author

need to update README.md

done

@spacewander spacewander merged commit e08ec60 into apache:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@membphis membphis membphis approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: support splunk hec logging plugin
4 participants
@shuaijinchao @spacewander @membphis @tzssangglass