Each upstream service only needs to create a health check instance, o… #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…therwise each work will periodically detect the upstream service. 每个上游服务只需要创建一个健康检查实例，否则每个work都会定时探活上游服务
membphis
approved these changes
Sep 24, 2019
|
I'll try to add some test case. |
|
test case: #587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…therwise each work will periodically detect the upstream service. 每个上游服务只需要创建一个健康检查实例，否则每个work都会定时探活上游服务
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
Summary
SUMMARY_HERE
Full changelog
Issues resolved
Fix #XXX