Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proxy-rewrite): make sure proxy-rewrite update the core.request.header cache #5914

Merged
merged 2 commits into from
Dec 24, 2021
Merged

fix(proxy-rewrite): make sure proxy-rewrite update the core.request.header cache #5914

merged 2 commits into from
Dec 24, 2021

Conversation

leslie-tsang
Copy link
Member

@leslie-tsang leslie-tsang commented Dec 24, 2021 •
edited by spacewander
Loading

What this PR does / why we need it:

Fix #5858

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander changed the title fix(proxy-rewrite): make sure proxy-rewrite hit the core.request.header cache fix(proxy-rewrite): make sure proxy-rewrite update the core.request.header cache Dec 24, 2021
@spacewander spacewander merged commit 9a1831d into apache:master Dec 24, 2021
bzp2010 pushed a commit to bzp2010/apisix that referenced this pull request Dec 30, 2021
@leslie-tsang @bzp2010
fix(proxy-rewrite): make sure proxy-rewrite update the core.request.h…
5ccc64e 
…eader cache (apache#5914)
bzp2010 pushed a commit to bzp2010/apisix that referenced this pull request Dec 30, 2021
@leslie-tsang @bzp2010
fix(proxy-rewrite): make sure proxy-rewrite update the core.request.h…
ab7e7f0 
…eader cache (apache#5914)
@leslie-tsang leslie-tsang deleted the bugfix/issue-5858 branch January 5, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@moonming moonming moonming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Using proxy-rewrite to overwrite the request header x-forwarded-proto failed
4 participants
@leslie-tsang @tokers @moonming @spacewander