Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(plugin): rewrite upstream info with plugin proxy-rewrite #594

Merged
merged 8 commits into from
Sep 27, 2019
Merged

feature(plugin): rewrite upstream info with plugin proxy-rewrite #594

merged 8 commits into from
Sep 27, 2019

Conversation

shuaijinchao
Copy link
Member

This plugin is used to separate uri, host, scheme and enable_websocket work in the upstream module. Through this plugin, the simplicity and independence of the upstream module can be maintained.
此插件用于分离upstream模块中的uri、host、scheme和enable_websocket功能。让upstream模块可以保持简洁和独立性。

Issues resolved

Fix #569

@membphis
Copy link
Member

https://travis-ci.org/iresty/apisix/builds/589504274#L810

please fix it first.

moonming
moonming requested changes Sep 26, 2019
View reviewed changes
conf/config.yaml Show resolved Hide resolved
doc/plugins/proxy-rewrite-cn.md Outdated Show resolved Hide resolved
doc/plugins/proxy-rewrite-cn.md Outdated Show resolved Hide resolved
doc/plugins/proxy-rewrite.md Outdated Show resolved Hide resolved
lua/apisix/plugins/proxy-rewrite.lua Outdated Show resolved Hide resolved
@shuaijinchao
Copy link
Member Author

OK, I will fix one by one.

@moonming
Copy link
Member

@shuaijinchao please press the resolve conversation button after you fix one problem, so that's will save time for us. GitHub's code review is powerful.
thx

membphis
membphis reviewed Sep 26, 2019
View reviewed changes
t/lib/server.lua Outdated Show resolved Hide resolved
@membphis membphis changed the title change: add upstream info rewrite plugin proxy-rewrite feature(plugin): rewrite upstream info with plugin proxy-rewrite Sep 27, 2019
@membphis membphis added this to the ver 0.8 milestone Sep 27, 2019
moonming
moonming requested changes Sep 27, 2019
View reviewed changes
t/plugin/proxy-rewrite.t Show resolved Hide resolved
@membphis membphis merged commit 25fd698 into apache:master Sep 27, 2019
@membphis
Copy link
Member

@shuaijinchao merged, many thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming requested changes

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ver 0.8
Development

Successfully merging this pull request may close these issues.

change: implement a new plugin, to modify scheme, uri, host and enable_websocket.
3 participants
@shuaijinchao @membphis @moonming