fix(limit-count): keep the counter if the plugin conf is the same #6151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tzssangglass
approved these changes
Jan 23, 2022
spacewander
requested review from
tzssangglass,
bisakhmondal,
bzp2010 and
shuaijinchao
starsz
approved these changes
Jan 24, 2022
bisakhmondal
approved these changes
Jan 24, 2022
| -- This method produces the same encoded string when the input is not changed. | ||
| -- Different calls with cjson.encode will produce different string because | ||
| -- it doesn't maintain the object key order. | ||
| stably_encode = require("dkjson").encode |
tokers
reviewed
Jan 25, 2022
| @@ -63,7 +63,7 @@ __DATA__ | |||
| GET /t | |||
| --- error_code: 400 | |||
| --- response_body | |||
| {"error_msg":"failed to check the configuration of plugin limit-count err: failed to validate dependent schema for \"policy\": value should match only one schema, but matches none"} | |||
| {"error_msg":"failed to check the configuration of plugin limit-count err: else clause did not match"} | |||
There was a problem hiding this comment.
The error messages is confusing after changes, it cannot help API callers troubleshoot effectively, will we have some enhancements?
There was a problem hiding this comment.
Sure. We can improve it in the jsonschema library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: