fix(admin): correct the count field of plugin-metadata/global-rule #6155
Conversation
Ok, I will be commit later. |
Already done. please see 7a2ce71. |
|
|
||
| __DATA__ | ||
|
|
||
| === TEST 1: list empty resources |
There was a problem hiding this comment.
Can we add some test cases for non-empty resources?
There was a problem hiding this comment.
Done. please see b94a86c.
t/admin/global-rules2.t
Outdated
| } | ||
| --- response_body | ||
| {"action":"set","node":{"key":"/apisix/global_rules/1","value":{"id":"1","plugins":{"proxy-rewrite":{"uri":"/"}}}}} | ||
| --- request |
There was a problem hiding this comment.
There is no need to repeat the two sections below?
There was a problem hiding this comment.
I want to add a test cases for non-empty resources like TEST 3, so put a new global rules.
There was a problem hiding this comment.
But you already set them (--- request, --- no_error_log) in https://github.com/apache/apisix/pull/6155/files#diff-150a3eabdca95c99b2f057a9981111fd3dc0f7c830999549b60ce791265319c3R28
There was a problem hiding this comment.
Got it, I have removed request and error log phrase.
spacewander
changed the title
What this PR does / why we need it:
Correct the count field of plugin-metadata. please see comment
Pre-submission checklist: