-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authz-keycloak): add token refresh/expire time configuration #6229
feat(authz-keycloak): add token refresh/expire time configuration #6229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No feature added?
The code has been implemented, but not covered by the documentation and test cases, apisix/apisix/plugins/authz-keycloak.lua Lines 316 to 327 in ec0fc2c
|
pls add description of |
I will add the test case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add these fields in
apisix/apisix/plugins/authz-keycloak.lua
Line 29 in 9b98f1d
properties = { |
Thanks for the advice |
In fact, the description of these two parameters is also missing |
I have tried adding test cases and descriptions. |
@tzssangglass The fix has been completed, thanks for review. |
hi @Belyenochi , thank you for contributing, pls fix Doc Lint check,just a little problem that needs to be fixed. |
Solved in 1c6b473 |
@tzssangglass hi tzssangglass, pls help to review and merge this PR. |
resolved #3479