Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(prometheus): replace wrong apisix_nginx_http_current_connections{state="total"} label #6327

Merged
merged 2 commits into from
Feb 16, 2022
Merged

change(prometheus): replace wrong apisix_nginx_http_current_connections{state="total"} label #6327

merged 2 commits into from
Feb 16, 2022

Conversation

nic-6443
Copy link
Member

What this PR does / why we need it:

Fix #6301

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@nic-6443 @tokers
Update apisix/plugins/prometheus/exporter.lua
7bab173 
Co-authored-by: Alex Zhang <tokers@apache.org>
@spacewander spacewander changed the title fix(prometheus): wrong fields in the metrics change(prometheus): fix wrong fields in the metrics Feb 16, 2022
@spacewander spacewander changed the title change(prometheus): fix wrong fields in the metrics change(prometheus): replace wrong apisix_nginx_http_current_connections{state="total"} label Feb 16, 2022
@spacewander spacewander merged commit 84eced6 into apache:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers left review comments

@tzssangglass tzssangglass tzssangglass approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: some mistakes in prometheus plugin
4 participants
@nic-6443 @spacewander @tokers @tzssangglass