Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(admin): empty nodes should be encoded as array #6384

Merged
merged 1 commit into from
Feb 21, 2022
Merged

change(admin): empty nodes should be encoded as array #6384

merged 1 commit into from
Feb 21, 2022

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
change(admin): empty nodes should be encoded as array
d1b3126 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review February 20, 2022 12:03
@spacewander
Copy link
Member Author

For Go program, after this fix, an empty nodes will be decoded to an empty slice instead of nil.

@tao12345666333 @nic-chen @bzp2010
Could you help me confirm if this change affects other projects? Thanks!

@tao12345666333
Copy link
Member

I will confirm if the ingress project will be affected.

@nic-chen
Copy link
Member

For Go program, after this fix, an empty nodes will be decoded to an empty slice instead of nil.

@tao12345666333 @nic-chen @bzp2010 Could you help me confirm if this change affects other projects? Thanks!

Thanks. Dashboard-related projects have no effect.

@spacewander spacewander merged commit e279dff into apache:master Feb 21, 2022
@spacewander spacewander deleted the fjen branch February 21, 2022 01:51
hongbinhsu pushed a commit to fitphp/apix that referenced this pull request Feb 23, 2022
Merge branch 'upstream' into origin
c58d084 
* upstream: (52 commits)
  feat: add kubernetes discovery module (apache#4880)
  docs: fix For L7 proxy -> For L4 proxy (apache#6423)
  fix(deps): upgrade jsonschema to 0.9.8 (apache#6407)
  docs: translate Chinese to English in en clickhouse-logger (apache#6416)
  docs: add zh proxy-control.md&modify other doc error (apache#6346)
  docs: update public API relative usage (apache#6318)
  docs(cn): remove datadog from sidebar & fix doc lint conf (apache#6411)
  fix(request-validation): should not limit the urlencoded post args number (apache#6396)
  docs: fix configuration file typo (apache#6395)
  docs(extern-plugin): the implementation of runner (apache#6336)
  docs: polishing skywalking-logger plugin's docs (apache#6377)
  doc: adjust the directory structure of observability's documents (apache#6391)
  change(admin): empty nodes should be encoded as array (apache#6384)
  fix: should not limit the header number (apache#6379)
  ci: remove unnecessary tmate action (apache#6367)
  fix(opentelemetry): batch_span_processor export zero length spans (apache#6349)
  feat(graphql): support http get and post json request (apache#6343)
  feat: support for configuring the number of etcd health check retries (apache#6322)
  feat(wasm): support getting request body (apache#6325)
  fix(hmac-auth): hmac-auth plugin sort array param (apache#6314)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-chen nic-chen nic-chen approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spacewander @tao12345666333 @nic-chen @tokers