-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(lint): import Chinese copywriting autocorrect linter #6568
Conversation
9591b30
to
aaf486d
Compare
* add Chinese copywriting lint job * autocorrect fix docs/zh/latest/**/*.md * fix CHANGELOG.md conflict between markdownlint and autocorrect Signed-off-by: kwanhur <huang_hua2012@163.com>
aaf486d
to
5e33d08
Compare
Signed-off-by: kwanhur <huang_hua2012@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
@kwanhur impressive! |
Signed-off-by: kwanhur <huang_hua2012@163.com>
Co-authored-by: leslie <59061168+leslie-tsang@users.noreply.github.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
…typo-zh-copywriting
Hi @kwanhur, I try to resolve those conflicts, but I don't know which change I should keep. Please resolve them 🙏 |
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Had resolved conflicts. Some ci jobs need to re-run manually, trigger them plz. |
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
Signed-off-by: kwanhur <huang_hua2012@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are good to go now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bcoz no other feedback, for now, LGTM.
p.s. I would still prefer using a specified commit id rather than the current way but looks good to me. 🙏
@kwanhur |
Signed-off-by: kwanhur <huang_hua2012@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: leslie <59061168+leslie-tsang@users.noreply.github.com> Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: leslie <59061168+leslie-tsang@users.noreply.github.com> Co-authored-by: 琚致远 <juzhiyuan@apache.org>
What this PR does / why we need it:
#6528
Pre-submission checklist: