Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(request-id): add algorithm support nanoid #6779

Merged
merged 6 commits into from
Apr 7, 2022
Merged

feat(request-id): add algorithm support nanoid #6779

merged 6 commits into from
Apr 7, 2022

Conversation

aikin-vip
Copy link
Contributor

Description

nanoid is faster than UUID

related repos:

  1. nanoid--------js
  2. nanoid--------lua
  3. nanoid--------c

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@aikin-vip aikin-vip changed the title feat(request-id) algorithm support nanoid feat(request-id): algorithm support nanoid Apr 1, 2022
@aikin-vip aikin-vip changed the title feat(request-id): algorithm support nanoid feat(request-id): add algorithm support nanoid Apr 1, 2022
tokers
tokers reviewed Apr 2, 2022
View reviewed changes
t/plugin/request-id.t Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Apr 2, 2022
View reviewed changes
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation in https://github.com/CriztianiX/lua-resty-nanoid is incorrect. We should fix it like:
https://github.com/stuartcarnie/lua-snowflake/blob/master/rockspec/snowflake-1.0-1.rockspec

@aikin-vip
Copy link
Contributor Author

The installation in https://github.com/CriztianiX/lua-resty-nanoid is incorrect. We should fix it like: https://github.com/stuartcarnie/lua-snowflake/blob/master/rockspec/snowflake-1.0-1.rockspec

fix

@aikin-vip
Copy link
Contributor Author

I think I've solved all the problems, please review. @spacewander @tokers

@spacewander spacewander merged commit 51eec3e into apache:master Apr 7, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@aikin-vip @Liu-Junlin
feat(request-id): add algorithm support nanoid (apache#6779)
82d0764
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@aikin-vip @spacewander
feat(request-id): add algorithm support nanoid (#6779)
8b29616
@aikin-vip aikin-vip deleted the feat-request-id-nanoid branch March 14, 2023 11:15
@liweitianux
Copy link
Contributor

Hi @aikin-vip , could you please have a look at the issue #8931, and hopefully resolve it. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuaijinchao shuaijinchao shuaijinchao approved these changes

@spacewander spacewander spacewander approved these changes

@tokers tokers Awaiting requested review from tokers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aikin-vip @liweitianux @spacewander @shuaijinchao @tokers