Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide 5xx error message from client #6982

Merged
merged 18 commits into from
May 5, 2022
Merged

fix: hide 5xx error message from client #6982

merged 18 commits into from
May 5, 2022

Conversation

leslie-tsang
Copy link
Member

Description

Fixes #6699 (issue)

Re-create this PR as the old one had no response

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander spacewander merged commit bd9f900 into apache:master May 5, 2022
@leslie-tsang leslie-tsang deleted the PR-6745 branch May 5, 2022 02:46
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@leslie-tsang @Liu-Junlin
fix: hide 5xx error message from client (apache#6982)
8985e7f 
Co-authored-by: 高亮亮 <gll287546@alibaba-inc.com>
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request May 27, 2022
@leslie-tsang @spacewander
fix: hide 5xx error message from client (apache#6982)
d6cb825 
Co-authored-by: 高亮亮 <gll287546@alibaba-inc.com>
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request May 29, 2022
@leslie-tsang @spacewander
fix: hide 5xx error message from client (apache#6982)
f6c76fc 
Co-authored-by: 高亮亮 <gll287546@alibaba-inc.com>
spacewander pushed a commit that referenced this pull request May 29, 2022
@leslie-tsang @spacewander
fix: hide 5xx error message from client (#6982)
9b0cc7a 
Co-authored-by: 高亮亮 <gll287546@alibaba-inc.com>
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@leslie-tsang @spacewander
fix: hide 5xx error message from client (#6982)
a4aa644 
Co-authored-by: 高亮亮 <gll287546@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming approved these changes

@tokers tokers tokers approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to hide 5xx error detail from the client, so that the detail is not leaked
4 participants
@leslie-tsang @spacewander @tokers @moonming