feat(xrpc): register variable redis_cmd_line #7041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
base on #7040 |
kwanhur
reviewed
May 14, 2022
| @@ -39,5 +39,6 @@ List in alphabetical order: | |||
| | route_name | core | name of `route` | | | |||
| | service_id | core | id of `service` | | | |||
| | service_name | core | name of `service` | | | |||
| | redis_cmd_line | Redis | the content of Redis command | | | |||
There was a problem hiding this comment.
Better shorten name redis_cmd or redis_command?
redis_cmd_line seems it'll return multi commands compact into one line. It just return one total command content, not just a redis command like hmset, right?
There was a problem hiding this comment.
yes, what it really means is command line.
spacewander
reviewed
May 15, 2022
spacewander
reviewed
May 16, 2022
spacewander
approved these changes
May 17, 2022
soulbird
approved these changes
May 17, 2022
bzp2010
approved these changes
May 17, 2022
bzp2010
approved these changes
May 17, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist