Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust some list uris of V3 API #7364

Merged
merged 3 commits into from
Jul 4, 2022
Merged

feat: adjust some list uris of V3 API #7364

merged 3 commits into from
Jul 4, 2022

Conversation

tzssangglass
Copy link
Member

Description

Fixes #7320

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass
Copy link
Member Author

wait for #7359

@tzssangglass tzssangglass marked this pull request as ready for review July 1, 2022 07:11
membphis
membphis reviewed Jul 1, 2022
View reviewed changes
apisix/admin/init.lua
@@ -47,8 +47,10 @@ local resources = {
consumers = require("apisix.admin.consumers"),
schema = require("apisix.admin.schema"),
ssl = require("apisix.admin.ssl"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should delete ssl, all right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a break change, if so, we need to do a lot of changes to test cases and docs, which can cause conflicts when next merge to master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can first implement the function to update test cases, documents and uri on master after next merge to master?

@spacewander spacewander merged commit 394890d into apache:next Jul 4, 2022
spacewander pushed a commit that referenced this pull request Aug 3, 2022
@tzssangglass
feat: V3 features from the next branch (#7585)
6accc81 
* ci: add next branche to CI coverage (#7359)

* feat: adjust some list uris of V3 API (#7364)

* feat: response body format (#7366)

* feat: support paging to get a list of objects  (#7379)

* feat: filter fields supported by all objects (#7391)

* resolve code review
@tzssangglass tzssangglass mentioned this pull request Aug 8, 2022
Merged
5 tasks
@tzssangglass tzssangglass deleted the v3_lu branch October 10, 2022 10:42
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@tzssangglass @Liu-Junlin
feat: V3 features from the next branch (apache#7585)
0b184ef 
* ci: add next branche to CI coverage (apache#7359)

* feat: adjust some list uris of V3 API (apache#7364)

* feat: response body format (apache#7366)

* feat: support paging to get a list of objects  (apache#7379)

* feat: filter fields supported by all objects (apache#7391)

* resolve code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis left review comments

@spacewander spacewander spacewander approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzssangglass @spacewander @membphis