Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upstream): http connection was put into https connection pool #7466

Merged
merged 1 commit into from
Jul 15, 2022
Merged

fix(upstream): http connection was put into https connection pool #7466

merged 1 commit into from
Jul 15, 2022

Conversation

spacewander
Copy link
Member

This bug is introduced in 3dddf41
Signed-off-by: spacewander spacewanderlzx@gmail.com

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander
fix(upstream): http connection was put into https connection pool
d5b579e 
This bug is introduced in apache@3dddf41
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review July 14, 2022 09:09
@spacewander spacewander merged commit 7b6b30f into apache:master Jul 15, 2022
spacewander added a commit to spacewander/incubator-apisix that referenced this pull request Aug 12, 2022
@spacewander
fix(upstream): http connection was put into https connection pool (ap…
3b46f89 
…ache#7466)

This bug is introduced in apache@3dddf41
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@atealxt
Copy link

atealxt commented Aug 16, 2022

This patch should hotfix to 2.13 LTS and 2.14 too.

It was such a headache which spent us a couple of hours to recover. I paste some notes/docs here just in case someone is searching similar scene:

Error behavior:
Http request accidental get unexpected response such as 404, wrong content from another route/upstream.

Steps to Reproduce:

  1. setup two HTTP routes A a.example.com, B b.example.com
  2. upload ssl certificate which SNI like *.example.com
  3. setup one HTTPS route C c.example.com
  4. request C followed by A and B will get disordered response.

spacewander added a commit that referenced this pull request Aug 17, 2022
@spacewander
fix(upstream): http connection was put into https connection pool (#7466
1892d99 
)

This bug is introduced in 3dddf41
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@vavikast vavikast mentioned this pull request Oct 25, 2022
Closed
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@spacewander @Liu-Junlin
fix(upstream): http connection was put into https connection pool (ap…
59ea1fe 
…ache#7466)

This bug is introduced in apache@3dddf41
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@wangfeng22
Copy link

why did this happen? some routes work well, but some return 404 pages not found. @spacewander

This was referenced Nov 9, 2022
Closed
Closed
@tokers tokers mentioned this pull request Dec 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@starsz starsz starsz approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@spacewander @atealxt @wangfeng22 @tokers @nic-6443 @starsz @tzssangglass