Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup variable before re list and watch #7506

Merged
merged 2 commits into from
Jul 22, 2022
Merged

fix: cleanup variable before re list and watch #7506

merged 2 commits into from
Jul 22, 2022

Conversation

zhixiongdu027
Copy link
Contributor

@zhixiongdu027 zhixiongdu027 commented Jul 20, 2022 •
edited by spacewander
Loading

Description

Fixs #7489

Checklist

  • [] I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@zhixiongdu027
Copy link
Contributor Author

Hi, @tokers @crazyMonkey1995

Please help review, Many tks.

@tokers
Copy link
Contributor

tokers commented Jul 21, 2022

I just re-ran the failed CI jobs.

@tzssangglass
Copy link
Member

pls rebase the upstream master branch to your PR branch, the CI failed has been fixed in the master branch of upstream.

@zhixiongdu027
Copy link
Contributor Author

@tzssangglass @tokers
Please help re start ci .

@spacewander
Copy link
Member

@tzssangglass @tokers Please help re start ci .

Done

@spacewander spacewander merged commit 3b1cda7 into apache:master Jul 22, 2022
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Aug 17, 2022
@zhixiongdu027 @spacewander
fix(k8s): cleanup variable before re list and watch (apache#7506)
890c4d5
spacewander pushed a commit that referenced this pull request Aug 17, 2022
@zhixiongdu027 @spacewander
fix(k8s): cleanup variable before re list and watch (#7506)
29541f5
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@zhixiongdu027 @Liu-Junlin
fix(k8s): cleanup variable before re list and watch (apache#7506)
c935d55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers left review comments

@tangzhenhuang tangzhenhuang tangzhenhuang left review comments

@spacewander spacewander spacewander approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhixiongdu027 @tokers @tzssangglass @spacewander @tangzhenhuang