Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless judge in pubsub init #7686

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions apisix/core/pubsub.lua
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,11 @@ local function init_pb_state()
-- initialize protoc compiler
protoc.reload()
local pubsub_protoc = protoc.new()

-- compile the protobuf file on initial load module
-- ensure that each worker is loaded once
if not pubsub_protoc.loaded["pubsub.proto"] then
pubsub_protoc:addpath("apisix/include/apisix/model")
local ok, err = pcall(pubsub_protoc.loadfile, pubsub_protoc, "pubsub.proto")
if not ok then
pubsub_protoc:reset()
return "failed to load pubsub protocol: " .. err
end
pubsub_protoc:addpath("apisix/include/apisix/model")
local ok, err = pcall(pubsub_protoc.loadfile, pubsub_protoc, "pubsub.proto")
if not ok then
pubsub_protoc:reset()
return "failed to load pubsub protocol: " .. err
end

pb_state = pb.state(nil)
Expand Down