Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the phases after proxy should run when 500 happens before proxy #7731

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix: the phases after proxy should run when 500 happens before proxy #7731

merged 1 commit into from
Aug 18, 2022

Conversation

spacewander
Copy link
Member

…(#7703)

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander spacewander marked this pull request as ready for review August 18, 2022 07:01
@leslie-tsang leslie-tsang self-requested a review August 18, 2022 07:29
membphis
membphis approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spacewander spacewander changed the title fix: the phases after proxy should run when 500 happens before proxy … fix: the phases after proxy should run when 500 happens before proxy Aug 18, 2022
@spacewander spacewander merged commit 8c47964 into apache:release/2.13 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spacewander @membphis @bzp2010 @monkeyDluffy6017 @tzssangglass @leslie-tsang