Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update redirect doc #8051

Merged
merged 4 commits into from
Oct 17, 2022
Merged

docs: update redirect doc #8051

merged 4 commits into from
Oct 17, 2022

Conversation

Hazel6869
Copy link
Contributor

@Hazel6869 Hazel6869 commented Oct 9, 2022 •
edited
Loading

Description

we can't get find the way that we can configure the redirect to a url like this https://apisix.apache.org/docs. But in fact, we support it, it will mislead users that we don't support it, so i resolve it.

Fixes #7945

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Hazel6869 Hazel6869 marked this pull request as draft October 9, 2022 06:26
@Hazel6869 Hazel6869 marked this pull request as ready for review October 9, 2022 07:59
tzssangglass
tzssangglass previously approved these changes Oct 9, 2022
View reviewed changes
SylviaBABY
SylviaBABY previously approved these changes Oct 10, 2022
View reviewed changes
@spacewander
Copy link
Member

screenshot-20221011-172507
Bad number?

@Hazel6869
Copy link
Contributor Author

Hazel6869 commented Oct 13, 2022 •
edited
Loading

screenshot-20221011-172507 Bad number?
@spacewander
Why bad number, i can access it.

@spacewander
Copy link
Member

It should be Fix #7945

@Hazel6869
Copy link
Contributor Author

It should be Fix #7945

thanks your suggestion, i have fix it.

@spacewander
Copy link
Member

Still have two # between Fix and the ID.

@Hazel6869
Copy link
Contributor Author

Still have two # between Fix and the ID.
sorry 😫 , have changed.

spacewander
spacewander previously approved these changes Oct 14, 2022
View reviewed changes
@spacewander spacewander mentioned this pull request Oct 14, 2022
Merged
5 tasks
guitu168
guitu168 reviewed Oct 14, 2022
View reviewed changes
docs/zh/latest/plugins/redirect.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/redirect.md Outdated Show resolved Hide resolved
@Hazel6869 @guitu168
Apply suggestions from code review
e8c4873 
Co-authored-by: Fei Han <97138894+hf400159@users.noreply.github.com>
@tzssangglass
Copy link
Member

@Hazel6869 pls fix conflicts

@Hazel6869
Copy link
Contributor Author

@Hazel6869 pls fix conflicts

has done, thanks

@tzssangglass tzssangglass changed the title feat: update redirect doc docs: update redirect doc Oct 17, 2022
@spacewander spacewander merged commit 1151d32 into apache:master Oct 17, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@Hazel6869 @guitu168 @Liu-Junlin
docs: update redirect doc (apache#8051)
a482d6b 
Co-authored-by: Fei Han <97138894+hf400159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitu168 guitu168 guitu168 approved these changes

@SylviaBABY SylviaBABY SylviaBABY approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@spacewander spacewander Awaiting requested review from spacewander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: we can configure the uri field in redirect plugin with the host
5 participants
@Hazel6869 @spacewander @tzssangglass @SylviaBABY @guitu168