perf: optimizing performance of router match with lrucache #8102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
requested changes
Oct 17, 2022
membphis
reviewed
Oct 17, 2022
|
and we should provide more information about the new performance before we merge this PR |
|
The following tests were done on my development machine. The number of workers is 1, disable access log, and disable the proxy-mirror and proxy-cache plugins, use one route master branch:flamegraph: perfflamegraph: In this scenario, performance is improved by 10.87% |
membphis
reviewed
Oct 18, 2022
spacewander
reviewed
Oct 18, 2022
apisix/core/ai_plane.lua
Outdated
| local route_flags = core.table.new(0, 2) | ||
| for _, route in ipairs(routes) do | ||
| if route.vars then | ||
| route_flags.vars = true |
There was a problem hiding this comment.
We could simplify it with an enable_ai_plane flag?
Suggested change
| route_flags.vars = true | |
| enable_ai_plane = false |
There was a problem hiding this comment.
in this case, enable_ai_plane is not a good name
membphis
previously approved these changes
Oct 18, 2022
membphis
reviewed
Oct 18, 2022
soulbird
reviewed
Oct 18, 2022
soulbird
approved these changes
Oct 18, 2022
spacewander
approved these changes
Oct 18, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist