refactor: adjusting the position of ai module #8120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
previously approved these changes
Oct 19, 2022
membphis
reviewed
Oct 19, 2022
soulbird
reviewed
Oct 19, 2022
membphis
previously approved these changes
Oct 19, 2022
membphis
reviewed
Oct 19, 2022
| @@ -38,7 +38,7 @@ __DATA__ | |||
| GET /t | |||
| --- response_body | |||
| etcd host: http://127.0.0.1:2379 | |||
| first plugin: "real-ip" | |||
| first plugin: "ai" | |||
There was a problem hiding this comment.
we can change the priority of ai plugin
we should avoid to change this test case
There was a problem hiding this comment.
If it is not necessary, I am going to change it in the next PR
spacewander
reviewed
Oct 20, 2022
| @@ -152,6 +152,8 @@ function _M.http_init_worker() | |||
|
|
|||
| apisix_upstream.init_worker() | |||
| require("apisix.plugins.ext-plugin.init").init_worker() | |||
| -- TODO: need to revisit code layering and avoid similar hacking | |||
There was a problem hiding this comment.
Will this be handled in the next PR?
There was a problem hiding this comment.
not in next PR, in feature.
spacewander
approved these changes
Oct 20, 2022
soulbird
approved these changes
Oct 20, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist