Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fixed os version of ubuntu #8438

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented Dec 1, 2022

Description

Fixes # (issue)
ref: actions/runner-images#6399

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass tzssangglass marked this pull request as ready for review December 1, 2022 08:26
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs-on: ubuntu-latest

We should use "find & replace" to update all the workflows?

@spacewander
Copy link
Member

Anyway, if the policy is to fix the CI and upgrade to 22.04 in the future, we can merge this PR now.

@tzssangglass
Copy link
Member Author

We should use "find & replace" to update all the workflows?

Since Dec 1, the default version of ubuntu-latest is 22.04. For workflows that are running on ubuntu-latest and work well, I think we don't need to downgrade back to 20.04.

if the policy is to fix the CI and upgrade to 22.04 in the future, we can merge this PR now.

+1

@spacewander spacewander merged commit 1935d4b into apache:master Dec 1, 2022
drgnchan pushed a commit to drgnchan/apisix that referenced this pull request Dec 2, 2022
hongbinhsu added a commit to fitphp/apix that referenced this pull request Dec 4, 2022
* upstream/master: (48 commits)
  fix(ai): remove BUILD_ROUTER event when ai module is unloaded (apache#8184)
  chore: add some comment for make_request_to_vault function (apache#8420)
  docs: update admin api English doc (apache#8227)
  ci: use fixed os version of ubuntu (apache#8438)
  feat: Support store secrets in secrets manager for auth plugin via kms components (apache#8421)
  feat: interact via gRPC in APISIX Admin API (apache#8411)
  fix: last_err can be nil when the reconnection is successful (apache#8377)
  feat: support global data encryption of secret information (apache#8403)
  refactor(env): rename funtion name (apache#8426)
  feat(admin): add kms admin api (apache#8394)
  docs: update consumer and upstream docs (apache#8223)
  ci: add cron job for GM (apache#8398)
  docs: add kms env doc (apache#8419)
  feat: Added log format support in syslog plugin. (apache#8279)
  feat: add vault common components (apache#8412)
  docs: update global-rule/plugin-config/plugin/ docs (apache#8262)
  docs: update consumer-group/router/service/script doc (apache#8332)
  feat: support store secret in env for auth plugin (apache#8390)
  docs: update Upgrade Guide CN version (apache#8392)
  docs: add GM plugin EN doc to make website display normally (apache#8393)
  ...
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Jan 5, 2023
spacewander added a commit that referenced this pull request Jan 6, 2023
Co-authored-by: tzssangglass <tzssangglass@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants