Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unregister timer when snowflake etcd keepalive failed #8556

Merged
merged 2 commits into from
Dec 26, 2022
Merged

fix: unregister timer when snowflake etcd keepalive failed #8556

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db4a7a3
bugfix: unregister timer when snowflake etcd keepalive failed
kingluo Dec 23, 2022
9ee87da
add test case
kingluo Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apisix/plugins/request-id.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ local function gen_data_machine(max_number)
if err4 then
snowflake_inited = nil
data_machine = nil
timers.unregister_timer("plugin#request-id")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test to ensure the number of unregister_timer call is correct? For instance, via injecting some code.

core.log.error("snowflake data_machine: " .. id .." lease failed.")
end
start_at = now
Expand Down