Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: kafka should register port in the zookeeper same as exposed #8672

Merged
merged 5 commits into from
Jan 18, 2023

Conversation

starsz
Copy link
Contributor

@starsz starsz commented Jan 12, 2023

Description

This PR is used to fix the CI of t/plugin/kafka-logger.t.

  1. Since the kafka will register host:port in the zookeeper, so we should keep the same port as exposed, else
    we will get the error log like this:

image

  1. Add no-error-log flag to check to ensure the access_log is sent to kafka successfully.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@starsz starsz changed the title ci: kafka port bind ci: kafka should register port in the zookeeper same as exposed Jan 12, 2023
@starsz starsz closed this Jan 13, 2023
@starsz starsz deleted the fix_kafka_docker branch January 13, 2023 02:02
@starsz starsz restored the fix_kafka_docker branch January 17, 2023 01:54
@starsz starsz reopened this Jan 17, 2023
@starsz starsz marked this pull request as ready for review January 17, 2023 06:19
@ronething
Copy link
Contributor

https://github.com/apache/apisix/actions/runs/3935628692/jobs/6731487434, this is the failed job link which cause something like connection refused.

Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spacewander spacewander merged commit b440a06 into apache:master Jan 18, 2023
@starsz starsz deleted the fix_kafka_docker branch January 18, 2023 02:35
hongbinhsu added a commit to fitphp/apix that referenced this pull request Jan 30, 2023
* upstream/master: (67 commits)
  fix: grpc-transcode plugin: fix map data population (apache#8731)
  change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua (apache#8660)
  feat: stream subsystem support consul_kv service discovery (apache#8633)
  fix(proxy-mirror): use with uri rewrite (apache#8718)
  ci: move helper script to the right dir (apache#8691)
  refactor(pubsub): simpify the get_cmd implementation (apache#8608)
  feat: stream subsystem support kubernetes service discovery (apache#8640)
  docs: fix deployment links (apache#8714)
  fix: remove backslash before slash when encoding (apache#8684)
  ci: kafka should register port in the zookeeper same as exposed (apache#8672)
  docs: fix plugin config naming (apache#8701)
  docs: fix code block (apache#8700)
  docs: rename kms to secret (apache#8697)
  docs: replace transparent logos with white background logos (apache#8689)
  fix: upgrade lua-resty-etcd to 1.10.3 (apache#8668)
  fix: upgrade casbin to 1.41.3 to improve performance (apache#8676)
  chore: make send_stream_request more clear (apache#8627)
  feat: stream subsystem support nacos service discovery (apache#8584)
  feat: stream subsystem support dns service discovery (apache#8593)
  refactor(admin): refactor resource routes (apache#8611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants