Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added Keyword API Gateway #8966

Closed
wants to merge 70 commits into from
Closed

docs: Added Keyword API Gateway #8966

wants to merge 70 commits into from

Conversation

Ajay-singh1
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 commented Feb 28, 2023

Description

Added Keyword API Gateway

Better SEO of the site

Fixes #7218

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Neilblaze
Copy link
Contributor

Neilblaze commented Mar 1, 2023

@Ajay-singh1 Thanks! But keeping the limelight on making the SEO better, apart from fixing typos and fixing translation issues, what made you add API Gateway to all the above pages? Do give a read where exactly API Gateway is being used and then update accordingly.

Once done, could you squash all commit messages into a single one?

cc: @navendu-pottekkat

@Ajay-singh1
Copy link
Contributor Author

Sure!

Copy link
Contributor

@Neilblaze Neilblaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ajay-singh1 Also, before you do that, switch to the master branch, update it to upstream, create a new branch from the master, make changes, commit, and create the pull request.

This was referenced Mar 1, 2023
Copy link
Member

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to the keywords list might be good, but I don't see the need to forcefully change APISIX to APISIX API Gateway everywhere.

@Ajay-singh1
Copy link
Contributor Author

Adding to the keywords list might be good, but I don't see the need to forcefully change APISIX to APISIX API Gateway everywhere.

I have rectified it.

@Neilblaze
Copy link
Contributor

@Ajay-singh1 I'm repeating, follow this first and then squash all commits into a single one. Make sure to perform a Sign-Off.

If you can't then lemme know, I'll cc you in a different PR which I'll open once you confirm.

@Ajay-singh1
Copy link
Contributor Author

I don't know how to squash all the commits.I am afraid it can lead to merge conflicts.Can you redirect me to a different PR?

Thanks for your review.

@Neilblaze
Copy link
Contributor

Neilblaze commented Mar 2, 2023

Okay, I'll do it by eod (IST).

@Neilblaze
Copy link
Contributor

Neilblaze commented Mar 2, 2023

@Ajay-singh1 you can close this PR now. Make sure to close the duplicate ones too!

@Ajay-singh1
Copy link
Contributor Author

PR #8993 Has The Fix!Closing the PR.

@Ajay-singh1 Ajay-singh1 closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add API Gateway keywords in English and Chinese docs
3 participants