-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added Keyword API Gateway #8966
Conversation
Update the text from Chinese to English as this repo contains English text
@Ajay-singh1 Thanks! But keeping the limelight on making the SEO better, apart from fixing typos and fixing translation issues, what made you add Once done, could you squash all commit messages into a single one? cc: @navendu-pottekkat |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ajay-singh1 Also, before you do that, switch to the master branch, update it to upstream, create a new branch from the master, make changes, commit, and create the pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding to the keywords list might be good, but I don't see the need to forcefully change APISIX to APISIX API Gateway everywhere.
@navendu-pottekat I have rectified the Docs.
I have rectified it. |
@Ajay-singh1 I'm repeating, follow this first and then squash all commits into a single one. Make sure to perform a Sign-Off. If you can't then lemme know, I'll cc you in a different PR which I'll open once you confirm. |
I don't know how to squash all the commits.I am afraid it can lead to merge conflicts.Can you redirect me to a different PR? Thanks for your review. |
Okay, I'll do it by eod (IST). |
@Ajay-singh1 you can close this PR now. Make sure to close the duplicate ones too! |
PR #8993 Has The Fix!Closing the PR. |
Description
Added Keyword API Gateway
Better SEO of the site
Fixes #7218
Checklist