fix: response-rewrite plugin can't add only one character #9372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulbird
reviewed
Apr 28, 2023
| --- request | ||
| GET /t | ||
| --- response_body | ||
| passed |
There was a problem hiding this comment.
Do you need to verify whether the header is valid?
There was a problem hiding this comment.
@soulbird Hi, this PR only fixes the issue of not being able to configure a single character and adds test coverage, which header can be verified to have been covered by the previous tests, not what this PR needs to do. 🤔
monkeyDluffy6017
approved these changes
Apr 28, 2023
soulbird
approved these changes
May 5, 2023
AlinsRan
pushed a commit
to AlinsRan/apisix
that referenced
this pull request
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix response-rewrite plugin can't add only one character
Fixes #9223
Checklist