Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream key config add mqtt_client_id support #9450

Merged
merged 6 commits into from
May 15, 2023

Conversation

AlinsRan
Copy link
Contributor

Description

Fixes #9449

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@monkeyDluffy6017
Copy link
Contributor

There are many variables and we cannot list them all.
how about rewrite like this: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L454

@AlinsRan
Copy link
Contributor Author

AlinsRan commented May 12, 2023

There are many variables and we cannot list them all. how about rewrite like this: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L454

I think constraints are necessary because they can help users follow the best practices.
Under constraints, many situations are predictable.
I believe that flexibility does not lie in having more options, but in providing better options.

@leslie-tsang leslie-tsang changed the title fix: failed to configure key: mqtt_client_id using upstream fix: upstream key config add mqtt_client_id support May 15, 2023
@leslie-tsang leslie-tsang merged commit 1d865fe into apache:master May 15, 2023
AlinsRan added a commit to AlinsRan/apisix that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: failed to configure key: mqtt_client_id using upstream
6 participants