fix(admin): fix secrets do not support to update attributes by PATCH #9510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An-DJ
changed the title
An-DJ
changed the title
|
@soulbird plz take a look : ) |
leslie-tsang
requested review from
kingluo,
monkeyDluffy6017,
soulbird and
leslie-tsang
soulbird
reviewed
May 23, 2023
| assert(prev_update_time ~= nil, "update_time is nil") | ||
| ngx.sleep(1) | ||
|
|
||
| local code, body = t('/apisix/admin/secrets/vault/test1', |
There was a problem hiding this comment.
Which field was modified? Didn't see how you verified the execution result of PATCH?
There was a problem hiding this comment.
TEST 4 changes the token to "unknown" by PATCH on path, then TEST 5 changes the token back to "apisix" by PATCH.
soulbird
approved these changes
May 24, 2023
monkeyDluffy6017
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Permit updating the selected attributes of the specified, existing secrets by PATCH.
Fixes #9503
Checklist