-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(response-rewrite): rewrite response code using ctx.var
#9633
Conversation
ctx.var
Are existing tests covered? |
There no clickhouse DB, it is hard to add test case. Do you have idea ? |
You may running the unit test code with |
d3f099e
to
c93a5a1
Compare
Hi @zhendongcmss, it looks that your test cases have failed |
c93a5a1
to
333d366
Compare
updated |
f6e69fb
to
35891e7
Compare
@zhendongcmss still failed |
35891e7
to
1b3831d
Compare
@zhendongcmss Please make the ci pass |
@leslie-tsang please help to fix this pr |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Description
I find that if I use logger plugin(clickhouse-logger) to send the access logs, the http code doesn't rewrited by response-rewrite plugin, because log-util.lua use
ctx.var
get the status notngx.status
.https://github.com/apache/apisix/blob/master/apisix/utils/log-util.lua#L63
Checklist