-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: file-logger add vars #9712
Conversation
@kamly please fix the code lint error |
test cases and docs are needed |
hi, @monkeyDluffy6017 all done
|
hi, @monkeyDluffy6017 fix~ |
@monkeyDluffy6017 , fix again ~ |
Refer to include_req_body and @kamly @monkeyDluffy6017 WDYT? |
Good idea, but I read in the docs that In the function _M.check_schema(conf, schema_type)
if schema_type == core.schema.TYPE_METADATA then
return core.schema.check(metadata_schema, conf)
end
local ok, err = core.schema.check(schema, conf)
if not ok then
return nil, err
end
return log_util.check_log_schema(conf)
end Compared in the function _M.check_schema(conf, schema_type)
if schema_type == core.schema.TYPE_METADATA then
return core.schema.check(metadata_schema, conf)
end
return core.schema.check(schema, conf)
end I think of these few steps:
The main reason is that I need this feature to be used in a production environment, and it is a big challenge for me to refactor @Gallardot @monkeyDluffy6017 WDYT ? |
In fact, apisix/apisix/plugins/file-logger.lua Lines 151 to 153 in bb0a0e6
apisix/apisix/utils/log-util.lua Line 228 in bb0a0e6
apisix/apisix/utils/log-util.lua Line 166 in bb0a0e6
If it doesn't meet your scenario, you can implement the apisix/apisix/utils/log-util.lua Line 108 in bb0a0e6
|
I got it ~ But apisix/apisix/plugins/file-logger.lua Lines 27 to 44 in bb0a0e6
Maybe the author who wrote it before missed it, I can try to align @monkeyDluffy6017 WDYT ? |
@Gallardot Please take a look ? |
@kamly |
@Gallardot got it, I have resubmitted following your solution. Please take a look ? in 900e438 |
@monkeyDluffy6017 @Gallardot , please take a look |
Hi @Gallardot, I don't get your point, how can we do this? each plugin is independent |
@monkeyDluffy6017 |
@monkeyDluffy6017 What else do I need to update? |
Co-authored-by: Liu Wei <375636559@qq.com>
Co-authored-by: Liu Wei <375636559@qq.com>
@monkeyDluffy6017 all fix again ~ |
Description
file-loggerr plugins add vars
fixes #9596
Checklist