-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mock plugin support adding headers #9720
Merged
moonming
merged 9 commits into
apache:master
from
shreemaan-abhishek:feat/mocking-headers
Jul 13, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
13d1f99
feat: support adding headers
shreemaan-abhishek bf261bb
rename attribute
shreemaan-abhishek f6d82af
clean
shreemaan-abhishek 9436a2f
add blank line
shreemaan-abhishek fc50ac1
add space
shreemaan-abhishek 5477ef2
add space
shreemaan-abhishek 565c649
add docs
shreemaan-abhishek d9dfdf7
fix chinese copywriting lint error
shreemaan-abhishek 98ac8ed
improve tests
shreemaan-abhishek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,7 +49,19 @@ local schema = { | |
-- specify response json schema, if response_example is not nil, this conf will be ignore. | ||
-- generate random response by json schema. | ||
response_schema = { type = "object" }, | ||
with_mock_header = { type = "boolean", default = true } | ||
with_mock_header = { type = "boolean", default = true }, | ||
response_headers = { | ||
type = "object", | ||
minProperties = 1, | ||
patternProperties = { | ||
["^[^:]+$"] = { | ||
oneOf = { | ||
{ type = "string" }, | ||
{ type = "number" } | ||
} | ||
} | ||
}, | ||
} | ||
}, | ||
anyOf = { | ||
{ required = { "response_example" } }, | ||
|
@@ -215,6 +227,12 @@ function _M.access(conf, ctx) | |
ngx.header["x-mock-by"] = "APISIX/" .. core.version.VERSION | ||
end | ||
|
||
if conf.response_headers then | ||
for key, value in pairs(conf.response_headers) do | ||
core.response.add_header(key, value) | ||
end | ||
end | ||
|
||
if conf.delay > 0 then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need a blank |
||
ngx.sleep(conf.delay) | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ngx.header[key] = value
instead? keep the same as line 227There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
core.response
is more efficient.